Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add support for top-level await syntax in linter #36911

Merged
merged 1 commit into from
Jan 15, 2021
Merged

tools: add support for top-level await syntax in linter #36911

merged 1 commit into from
Jan 15, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 13, 2021

Necessary for #36848.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 13, 2021
@aduh95 aduh95 mentioned this pull request Jan 13, 2021
Merged
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 13, 2021 •
edited by aduh95
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/35528/ ✅

@aduh95
tools: add support for top-level await syntax in linter
49f900e 
PR-URL: nodejs#36911
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@aduh95 aduh95 merged commit 49f900e into nodejs:master Jan 15, 2021
@aduh95 aduh95 deleted the tla-lint branch January 15, 2021 23:33
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@aduh95 @ruyadorno
tools: add support for top-level await syntax in linter
8dc8adc 
PR-URL: #36911
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
tools: add support for top-level await syntax in linter
ef1aab1 
PR-URL: #36911
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @targos @cjihrig